Parse REVOKE GRANT OPTION FOR - #2431
Merged
Merged
Conversation
LucaCappelletti94
marked this pull request as ready for review
August 5, 2026 16:47
Contributor
Author
|
@iffyio this is the last one of the < 100 lines PRs I opened, the other ones are all larger. I tried to keep them as tiny as possible, but most of those are regarding adding statements support so they tend to be naturally larger. |
iffyio
approved these changes
Aug 25, 2026
iffyio
left a comment
iffyio
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks @LucaCappelletti94!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GRANT ... WITH GRANT OPTIONparses today but theREVOKEstatement that withdraws that option did not, and this PR closes that gap.Also, I noticed that there was a
test_revoke_with_cascadewhich excludedMySqlDialect, which has no reason to be I could identify, so I removed the filter.